Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): new login flow #8387

Open
wants to merge 12 commits into
base: canary
Choose a base branch
from
Open

Conversation

darkskygit
Copy link
Member

fix AF-1406

@graphite-app graphite-app bot requested review from Brooooooklyn, pengx17, forehalo, EYHN and JimmFly and removed request for JimmFly September 25, 2024 08:07
Copy link

graphite-app bot commented Sep 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

darkskygit commented Sep 25, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 48.36364% with 142 lines in your changes missing coverage. Please review.

Project coverage is 65.40%. Comparing base (2c9ef91) to head (e474841).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ges/backend/server/src/plugins/oauth/controller.ts 46.87% 119 Missing ⚠️
...s/frontend/core/src/modules/cloud/services/auth.ts 0.00% 16 Missing ⚠️
...ore/src/modules/desktop-api/service/desktop-api.ts 0.00% 4 Missing ⚠️
packages/frontend/core/src/utils/channel.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8387      +/-   ##
==========================================
- Coverage   65.62%   65.40%   -0.23%     
==========================================
  Files         730      730              
  Lines       41518    41735     +217     
  Branches     4122     4133      +11     
==========================================
+ Hits        27248    27296      +48     
- Misses      13833    14003     +170     
+ Partials      437      436       -1     
Flag Coverage Δ
server-test 77.90% <52.58%> (-0.37%) ⬇️
unittest 35.62% <4.16%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkskygit darkskygit force-pushed the darksky/adapt-auth-code-mode branch from 1720015 to 91040f2 Compare November 28, 2024 07:34
@darkskygit darkskygit force-pushed the darksky/adapt-auth-code-mode branch from 91040f2 to 34b2cb6 Compare December 2, 2024 08:16
@darkskygit darkskygit force-pushed the darksky/adapt-auth-code-mode branch from 34b2cb6 to 96ea0dc Compare December 3, 2024 03:18
@darkskygit darkskygit force-pushed the darksky/adapt-auth-code-mode branch from 96ea0dc to de82bf0 Compare December 9, 2024 10:28
@darkskygit darkskygit changed the title feat: new login flow feat(server): new login flow Dec 10, 2024
@darkskygit darkskygit force-pushed the darksky/adapt-auth-code-mode branch 2 times, most recently from 8d5144c to 67c755f Compare December 16, 2024 08:17
@darkskygit darkskygit force-pushed the darksky/adapt-auth-code-mode branch from 67c755f to e474841 Compare December 20, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants